Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py/client-ticking): Support windows build for py/client-ticking #6198

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(py/client-ticking): Support windows build for py/client-ticking #6198

wants to merge 2 commits into from
+25 −2

Conversation

jcferretti
Copy link
Member

@jcferretti jcferretti commented Oct 14, 2024 •
edited
Loading

Still draft due to some unit tests failing on win32.

@jcferretti jcferretti added this to the 0.37.0 milestone Oct 14, 2024
@jcferretti jcferretti requested a review from kosak October 14, 2024 02:39
@jcferretti jcferretti self-assigned this Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

Cristian Ferretti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@jcferretti
Copy link
Member Author

jcferretti commented Oct 14, 2024 •
edited
Loading

capture_003_13102024_223106

capture_004_13102024_223804

capture_005_13102024_223826

@jcferretti
Copy link
Member Author

jcferretti commented Oct 14, 2024 •
edited
Loading

Turns out you can write non-portable code in pure python.

capture_006_13102024_230021

SIGALARM only exists in Unix, not in Windows

capture_002_20241013_232024

assertEquals is deprecated and seems to be already removed in Windows python3.12 (at least).
https://bugs.python.org/issue9424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosak kosak Awaiting requested review from kosak

@chipkent chipkent Awaiting requested review from chipkent chipkent will be requested when the pull request is marked ready for review chipkent is a code owner

@jmao-denver jmao-denver Awaiting requested review from jmao-denver jmao-denver will be requested when the pull request is marked ready for review jmao-denver is a code owner

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy will be requested when the pull request is marked ready for review rcaudy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jcferretti jcferretti

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jcferretti